-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward options’ ssl.key even when non-enumerable #2394
Forward options’ ssl.key even when non-enumerable #2394
Conversation
da2bae7
to
4c2fce2
Compare
Hey @charmander - thank you so much for diving in to this & trying to get it working. I know working with travis can be pretty incredibly painful...yesterday it took >2 hours for some tests to run. Would me upgrading to a paid plan help w/ the turn-around time there? Also, wondering if it'd be worthwhile for me to take the functional change to the code & write a unit test (and mock the ssl socket call) to check it's working and we can work on the larger travis integration tests in another PR? That way we can close the actual bug fast? |
7587128
to
5f86903
Compare
Hmm… well, how would you feel about a PR that switched the CI to GitHub Actions?
I’ve decided to write just one integration test that runs in its own CI job. When the tests are refactored to read configuration consistently, it won’t be needed anymore :) Sorry it took so long to get back to this. |
8ed686f
to
d2cebd9
Compare
3d35ed5
to
b18e725
Compare
I would feel great about that.
dope
100% no worries at all. Take all the time you want! Sorry travis was blocking you. |
release pg@8.5.0 |
Fixes #2392.